Repository navigation
arm64: dts: apple: t8142-j815: MagSafe 3 PD controller - #1907
RyanTheTide merged 2 commits into
Conversation
|
@DjDeveloperr out of draft, parent-first on #1532 (alias fix merged in). On the 27.2 stub: sn201202x at 1-08, all three Type-C ports, and the MagSafe power supply registered. Please review. Assisted-by: Claude Opus 5.5 |
7a196b1 to
c3e48b3
Compare
|
Blockers: 2. The node matches the J714s MagSafe controller (same compatible, SID, no interrupts on the polled bus,
HW row: J815 on the rebased kernel and DTB, default command line: with a MagSafe charger attached, Assisted-by: LLM (Claude:Opus 5.5) |
hpm5 on nub-spmi-a0 (SID 8) is the MagSafe 3 port's PD controller (ADT
port-type 0x11). It has no USB data path, so it gets no connector node;
tipd registers a Type-C port and a power supply for it, as on J714s. The
bus is polled on T8142, so like hpm0 and hpm1 it has no interrupts. Its
ADT features-supported is <3> ("Power In" only), so it is marked
apple,no-liquid-detection.
Like hpm0 and hpm1, it takes the sleep's command rules
(apple,sleep-ssps-rules), as the J714s's MagSafe controller does. It does
not get apple,sleep-ssps: no SSPS run on it has been made yet, and a
controller that refuses S3 refuses the sleep.
Signed-off-by: Nick <nekreshen@yandex.ru>
c3e48b3 to
6dd5889
Compare
|
@RyanTheTide fixed.
hpm5 doesn't get Assisted-by: LLM (Claude:Opus 5.5) |
|
Re-review of 6dd5889: No blockers. Earlier points: 1 resolved: hpm5 now has HW row: J815 on this head, default command line: with a MagSafe charger attached, Assisted-by: LLM (Claude:Opus 5.5) |
|
Merge-train note: #1806 landed in batch 1 (integration/aurora 606d37e) and conflicts with this branch in |
Signed-off-by: Nick <nekreshen@yandex.ru> # Conflicts: # arch/arm64/boot/dts/apple/t8142-j815.dts
RyanTheTide
left a comment
There was a problem hiding this comment.
Re-checked at 8d16bfb. The merge keeps both sides in t8142-j815.dts: the MagSafe PD controller node, then the t8142-j813-j815-sleep.dtsi and t8142-j813-dcpext.dtsi includes from integration/aurora. Against the current tip the branch adds only its one file (+17), the commit reviewed before. Approving at this head.
Assisted-by: LLM (Claude:Opus 5.5)
|
@RyanTheTide merged In
Assisted-by: LLM (Claude:Opus 5.5) |
85e255d
into
aurora-silicon:integration/aurora
Adds the J815's MagSafe 3 PD controller, as #1686 did for the J714s.
From the J815 ADT:
hpm5on nub-spmi-a0, SID 8,port-type0x11 (MagSafe),features-supported<3> ("Power In" only).apple,no-liquid-detection(usb: typec: tipd: sn201202x: skip liquid detection where the port has none #1685): the port has no LDCM.apple,sleep-ssps-rules, as hpm0 and hpm1 now have inintegration/aurora(6465f0a) and as the J714s's MagSafe hpm5 has. So all three J815 controllers are talked to under the sleep's command rules. It doesn't getapple,sleep-ssps: no SSPS run has been made on it, and a controller that refuses S3 refuses the sleep.Changed on this head (review): rebased onto
integration/auroracc14570 (the conflict was next to the new hpm0/hpm1 rules), andapple,sleep-ssps-rulesadded to hpm5.Tested on J815 (MacBook Air 15" M5), macOS 27.2 stub, on the earlier head:
sn201202xbinds SPMI1-08. The J815 now has 3 Type-C ports (hpm0 1-0c, hpm1 1-0a, hpm5 1-08).tps6598x-source-psy-1-08.Checks on this head: the J813/J815 DTBs build,
dt_binding_checkandCHECK_DTBSwithapple,sn201202x.yamlare clean, andcheckpatch --strictis clean.Still owed (HW row): J815 on the rebased kernel and DTB, with the default command line. With a MagSafe charger attached,
tps6598x-source-psy-1-08reports online=1 with a sane voltage and current, and an unplug and replug updates it. Then one s2idle cycle with the charger and one without, with no tipd errors on resume; 0 SELinux denials, 0 failed units, 0 new kernel errors.Part of the J815 bring-up: board results are summarised in discussion #135.
Assisted-by: LLM (Claude:Opus 5.5)