Repository navigation
soc: apple: clpc: Take the Low Power mode ceiling from the DT - #1906
m0d16l14n1 wants to merge 2 commits into
Conversation
|
@DjDeveloperr ready for review: on the J815, Low Power mode takes the P cluster 4464 → 2220 → 4464 MHz through platform_profile, the ceiling from the ADT's cpu-low-power-frequency-max. Green and mergeable. Assisted-by: Claude Opus 5.5 |
|
The J813 has the same value. Its macOS 27.0 ADT's Tested on my J813 (macOS 27.2 stub) with this commit,
🤖 Generated with Claude Code |
|
Thanks for wiring up the Low Power mode ceiling on the M5, and for quoting the ADT value it comes from. One request on how it is selected. In this tree we pick behaviour by a hardware property, not by the list of machines it was checked on. Could the ceiling come from the device tree instead? For example, the boot loader copies If it helps, we can run Low Power mode rows on our M1 Pro, M2, M4 Pro and A18 Pro once it is property-driven. |
c67c59b to
39d354e
Compare
|
@RyanTheTide done, new head 39d354e:
The ADT values are 2220 MHz on J704, J813 and J815, 2088 on J713 and 3144 on J700. A J815 run through the property is in the next test build. Your Low Power rows on M1 Pro, M2, M4 Pro and A18 Pro would be very welcome. Assisted-by: Claude Opus 5.5 |
|
J815 boot on head 39d354e with aurora-silicon/aura#358 as Stage 2: aura read the ceiling from the ADT and passed it on. The boot didn't get to the platform_profile frequency check (low-power with one busy core). That row still needs to be run. |
|
Thanks for 39d354e and the loader side, and for the J815 log showing the ceiling arriving from the ADT. One coordination point: #1796 adds |
|
J813 (MacBook Air 13" M5), macOS 27.2 stub, with 39d354e and aura#358 on sithglan's J813 aura branch:
This replaces the local 🤖 Generated with Claude Code |
|
Hi, #1796 adds a property for the same ADT key on the M4 Pro and M4 Max MacBook Pros: Could we use Once your loader fills it on every machine, the four board values in #1796's 🤖 Generated with Claude Code |
|
On the property name: we're happy with |
39d354e to
6a1c203
Compare
|
Switched to
gig3m, your J813 row used the old The J815 Assisted-by: Claude Opus 5.5 |
|
Thanks for switching to |
|
J813 (MacBook Air 13" M5), macOS 27.2 stub, rerun with the new name: 6a1c203 (and 12d2875) in place of the old head, and aura#358 a92cf055 on sithglan's J813 aura branch 8b9c92ea:
🤖 Generated with Claude Code |
|
Thanks for the J813 rerun with the new property name: the ceiling coming from the DT alone on a board the machine list doesn't name is what we wanted to see. 6a1c203 now conflicts with integration/aurora. Could you rebase it? Our J616s row with aura#358 will run on the rebased head. |
|
J616s (MacBook Pro 14" M4 Pro, T6040) row, plus the rebase. Row (6a1c203 on our fleet77 kernel, loader with aura#358):
Rebase. 6a1c203 conflicts with 48c99cf on integration/aurora, which gave T6041 its own table and removed if (!of_property_read_u32(dev->of_node, "apple,low-power-frequency-max-mhz", &mhz))
clpc->low_power_khz = mhz * 1000;
else
clpc->low_power_khz = clpc->hw->low_power_khz;On integration cc14570 with that resolution, the CLPC KUnit suite passes on arm64 (13 pass, 1 skipped). The stock Could you push the rebase (yours or the above)? It needs no new hardware row for T6040, because the conflict touches only the T6041 table. |
Let the boot loader pass the CPU frequency ceiling of macOS's Low Power mode, which the ADT has as pmgr/clpc cpu-low-power-frequency-max, on the performance controller node. The property keeps the ADT's unit (MHz), so the loader copies the value as it is. The name and text match the property proposed for the same ADT key on the M4 Pro and Max MacBook Pros. Signed-off-by: Nick <nekreshen@yandex.ru>
The ADT has macOS's Low Power mode CPU ceiling as pmgr/clpc cpu-low-power-frequency-max: 2220 MHz on the J704, J813 and J815 (M5), 2088 MHz on the J713 (M4 Air), 3144 MHz on the J700. The boot loader now copies it into the CLPC node as apple,low-power-frequency-max-mhz. Register the low-power platform profile wherever the node has that property, with its value as the ceiling. A node without it keeps the SoC's built-in value where there is one, so the T6041 and T8140 profiles stay as they are under an older loader. With the same ceiling built into the driver for the J815, low-power took its P cluster from 4464 to 2220 MHz and back (M5, 27.2 stub). Signed-off-by: Nick <nekreshen@yandex.ru>
6a1c203 to
0cbf68d
Compare
|
@RyanTheTide thanks for the J616s row and the resolution. Rebased onto cc14570 with exactly that: the DT property, else Checks: Assisted-by: LLM (Claude:Opus 5.5) |
|
Thanks. 0cbf68d reads Assisted-by: LLM (Claude:Opus 5.5) |
|
J616s (MacBook Pro 16" M4 Pro, T6040) row with this head (0cbf68d) merged on integration/aurora a463112. Same kernel also merged #2549, #2784 and #2021, fleet78 config, production J616s Device Tree. The loader writes
Two things to know before this lands:
Assisted-by: LLM (Claude:Opus 5.5) |
|
#2784 has landed and conflicts with this in Assisted-by: LLM (Claude:Opus 5.5) |
The CLPC's Low Power mode ceiling now comes from the device tree, so any machine whose ADT has one gets the low-power platform profile. Before, it was a constant on the T8142 profile, limited to
apple,j815.apple,low-power-frequency-max-mhzon the CLPC node (the ADT's unit, so the loader copies it unchanged).hw->low_power_khz) where there is one. The ceiling code (apple_clpc_profile_ceilings()and theprofile:debugfs line) reads the resultingclpc->low_power_khz.The boot loader copies the ADT's
pmgr/clpccpu-low-power-frequency-max(MHz) into the property: aurora-silicon/aura#358. The value is 2220 MHz on J704, J813 and J815, 2088 MHz on J713 and 3144 MHz on J700.Rebased onto
integration/auroracc14570, with the resolution Ryan posted for the conflict with 48c99cf (T6041's own table,low_power_machineremoved): DT property, elsehw->low_power_khz.Rows:
Needs
CONFIG_ACPI=y, because the platform profile class is only compiled with ACPI. On this device-tree boot ACPI stays disabled at run time.Checks on this head:
W=1adds no warnings indrivers/soc/apple/;checkpatch --strictclean;dt_binding_checkonapple,pmc.yamlandCHECK_DTBSon the J813/J815 DTBs are clean.Part of the J815 bring-up; board results are summarised in #135.
Assisted-by: LLM (Claude:Opus 5.5)