Repository navigation
crypto: apple: T8142 (M5) SIO AES engine, enabled on J815 - #1905
Conversation
|
@DjDeveloperr ready for review: rev 5 engine on the J815 (27.2 stub), ecb/cbc/ctr-aes-apple-sio self-tests pass. Green and mergeable. Assisted-by: Claude Opus 5.5 |
0529692 to
02b9425
Compare
|
Rebased onto current
🤖 Generated with Claude Code |
|
Blockers: 1. The driver match (drivers/crypto/apple-aes.c:709) and the binding entry are consistent with the T8140 rev-5 data. The DT nodes carry the ADT windows, IRQ 1246 and DART-SIO stream 1,
HW row: J815 and J813 on this head with the default command line. Assisted-by: LLM (Claude:Opus 5.5) |
The M5's SIO AES engine is the T8140 one (ADT aes-version 5, the same three register windows). Add its compatible. Signed-off-by: Nick <nekreshen@yandex.ru>
The J815 ADT describes the M5's SIO AES engine as revision 5 with the T8140's register windows, so match apple,t8142-aes to the revision 5 data. Signed-off-by: Nick <nekreshen@yandex.ru>
From the J815 ADT: /arm-io/aes (aes,s8000, aes-version 5) with the engine, shared control and auxiliary control windows at 0x3a500c000, 0x3882dc000 and 0x388078000, IRQ 1246, on DART-SIO stream 1 (mapper-aes). Its power state is PMGR device AES (id 96, +0x3a0) under SIO (id 66, +0x2b0), which the SIO firmware owns. Add both power states and the engine, disabled, and give the SIO DART its power domain. Signed-off-by: Nick <nekreshen@yandex.ru>
Enable the SIO AES engine and its SIO DART and power states on both M5 MacBook Airs. The engine is part of the T8142, and the J813 includes the same SoC description with no board-specific wiring for it. The engine registers below the CPU's aes-ce, so it is used only when asked for by driver name. Signed-off-by: Nick <nekreshen@yandex.ru>
02b9425 to
8cc2127
Compare
|
@RyanTheTide done.
HW rows owed: the J815 and J813 self-tests, then s2idle + Assisted-by: LLM (Claude:Opus 5.5) |
|
Re-review of 8cc2127: No blockers. Earlier points: 1 (commit trailers) resolved: all four commits carry only the human Signed-off-by. 2 resolved: the Since the last review only the enables moved and the branch was rebased; the binding, the driver match (drivers/crypto/apple-aes.c:709) and the SoC nodes are unchanged. Nit: the title still says "enabled on J815"; it is now both J813 and J815. HW row: J815 and J813 on this head with the default command line: Assisted-by: LLM (Claude:Opus 5.5) |
|
Merge-train note: #1806 (same board, J815 DP alt-mode) landed on integration/aurora in batch 1 (tip 606d37e) and now conflicts with this branch in |
Signed-off-by: Nick <nekreshen@yandex.ru> # Conflicts: # arch/arm64/boot/dts/apple/t8142-j813-j815.dtsi
RyanTheTide
left a comment
There was a problem hiding this comment.
Re-checked at 73bb6dd. The merge's only resolution is in t8142-j813-j815.dtsi: the &jpeg1 block from integration/aurora stays, and the SIO AES block (&ps_sio, &ps_aes, &sio_dart, &aes) follows it unchanged. Against the current tip the branch adds exactly its 4 files (+61), the same commits reviewed before. Approving at this head.
Assisted-by: LLM (Claude:Opus 5.5)
|
@RyanTheTide merged The only conflict was in
Assisted-by: LLM (Claude:Opus 5.5) |
4ac9958
into
aurora-silicon:integration/aurora
Enables the M5's (T8142) SIO AES engine on both M5 MacBook Airs (J813, J815). The driver already handles revision 5 (#1622), so this adds the T8142 compatible, the DT nodes and the enables.
From the J815 ADT (
/arm-io/aes,aes,s8000,aes-version5):0x3a500c000, shared control0x3882dc000, auxiliary control0x388078000.mapper-aes).+0x3a0) under SIO (id 66,+0x2b0). SIO is owned by its firmware, sops_sioisapple,firmware-owned. The SIO DART getsps_sioas its power domain.Commits: binding → driver match (
apple,t8142-aes→ revision 5 data) → T8142 nodes (disabled) → enables int8142-j813-j815.dtsi.Changed on this head (review): the four enables moved from
t8142-j815.dtsto the sharedt8142-j813-j815.dtsi, because the engine is part of the SoC and the J813 has no board-specific wiring for it. The J813's DTB therefore changes, and it has no row yet. Rebased ontointegration/auroracc14570.The engine registers at priority 150, below the CPU's
aes-ce, so it is used only when asked for by driver name, as on the J616s and J700.Tested on J815 (MacBook Air 15" M5), macOS 27.2 stub, on the earlier head (same driver and nodes):
apple-sio-aes-crypto 3a500c000.crypto: AES engine rev 5 ready (readiness 0x01023f80, 42-bit DMA, ECB/CBC/CTR, priority 150)/proc/crypto:ecb-aes-apple-sio,cbc-aes-apple-sio,ctr-aes-apple-sio, allselftest: passed.version 0204, 16 streams, AS 42 -> 42.Checks on this head:
W=1adds no warnings indrivers/crypto/at any commit, the J813 and J815 DTBs build,dt_binding_checkandCHECK_DTBSwithapple,aes.yamlare clean on both, andcheckpatch --strictis clean.Still owed (HW rows): J815 and J813 on this head with the default command line:
/proc/cryptolists the three algorithms withselftest: passed; then one s2idle cycle andmodprobe -r apple-aes && modprobe apple-aes, and the self-tests pass again. This checks that the SIO firmware brings the engine's domain back after a sleep, sinceps_siois firmware-owned. Pass also needs 0 SIO DART faults, 0 failed units and 0 new kernel errors.Part of the J815 bring-up: board results are summarised in discussion #135.
Assisted-by: LLM (Claude:Opus 5.5)