Repository navigation
config, main, data: key camera profiles on sysfs sensor name ([sensor:imx958-uw]) - #14
Conversation
|
Thanks for bringing the J616c up and for checking the stream live on it. One thing about where the values live. We would rather key these profiles by the sensor module the camera driver reports (the ISP's sensor identity), so every Mac with an IMX958 picks up the same block and only a genuinely different module needs a new entry. We'll look at exposing that key from the daemon side; if you'd like to take it on instead, a section name like |
Replace per-board [apple,j616s] / [apple,j616c] entries in boards.conf with [sensor:imx958-uw], covering J614s, J616s, J614c, J616c, and other 12 MP Center Stage IMX958 ultra-wide machines from a single section. Read /sys/class/video4linux/<dev>/device/sensor at startup, on V4L2 node discovery, and once streaming begins (handling deferred-start ISPs that return -ENODATA until the first stream), falling back to [<compatible>] when the sensor attribute is absent or has no sensor-specific section. Signed-off-by: Artyom Astafurov <artyom.astafurov@gmail.com>
84e9529 to
e321770
Compare
|
Makes complete sense — thank you! Paired this 1:1 with
|
|
Thank you for taking this on, including the kernel side: one |
[sensor:imx958-uw] replaced [apple,j616s], but the sensor key comes from the apple-isp sysfs attribute that only kernels with aurora-silicon/linux#2216 have, and those report it only once the camera has been detected. Until then the J616s matched no section and lost its low-light thresholds and framing capability. Keep [apple,j616s] with the same values as the compatible fallback, and test that the J616s without a sensor still gets it. Signed-off-by: DjDeveloperr <hey@djdev.me>
|
@astaff I added 7b32b8f. I ran the real parser (
Review notes (none blocking):
|
|
Merged as 03cd679 after linux#2216. tests/test_config.c passes (gcc). Real-parser matrix: j616s keeps its values without the sensor attribute, j616c/j616s use [sensor:imx958-uw] when reported, j700 is unchanged (Neo TEST: sensor imx558, falls back to apple,j700). |
|
M4 Pro (J616s) row on 7b32b8f: pass. I ran the real loader from
fps <= 30 and the 30-frame ramp are the same in every row. |
Pair with aurora-silicon/linux#2216 (
apple-ispdevice/sensorsysfs attribute) to select camera low-light thresholds and framing capabilities by sensor module rather than per-board lists:[apple,j616s]indata/boards.confwith[sensor:imx958-uw], coveringJ614s,J616s,J614c,J616c, and other 12 MP Center Stage IMX958 ultra-wide machines from a single section while keeping[<compatible>](such as[apple,j700]) as fallback whendevice/sensoris absent or has no sensor-specific section./sys/class/video4linux/<dev>/device/sensorat startup, on PipeWire V4L2 node discovery, and when input streaming begins (sodeferred_startISPs that return-ENODATAuntilapple_isp_start_camera()runs upgrade cleanly to[sensor:...]on first stream).tests/test_config.ccovering[sensor:imx958-uw]precedence, userdenoise.confoverrides, driver symlink filtering, and deferred sensor population.