Fix shell quoting in preprocessor invocations - #517
Open
drshade wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for building MicroHs! Its awesome.
I'm using it whilst building something to run user-authored haskell schemas, validators, and queries etc, and am using the microhs frontend to inspect types etc.
Found a bug when it's installed in a directory containing spaces (and likely other characters too), so see commits which led to a fix - effectively just quoting those paths. Added a test too - but I'm not sure if that is warranted for this small change - you are welcome to remove it or ask me to update the PR.
All the best
Tom