Skip to content

Crash and error fixes #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UncleGrumpy wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Crash and error fixes #64

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dfc13a
Fix crash in API usage
UncleGrumpy Jul 25, 2026
90c4ff8
Prevent crash on missing chunk_refs
UncleGrumpy Jul 25, 2026
eca1a96
Use consistent error format
UncleGrumpy Jul 25, 2026
5e19f6e
Report error on write failures
UncleGrumpy Jul 25, 2026
66c7f0a
Prevent early termination on module_not_found error
UncleGrumpy Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/packbeam_api.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ is_beam(AVMElement) ->

%% @private
get_flags(AVMElement) ->
proplists:get_value(flags, AVMElement).
proplists:get_value(flags, AVMElement, 0).

%% @private
parse_files(InputPaths, Lib, StartModule, IncludeLines) ->
Expand Down Expand Up @@ -398,7 +398,7 @@ load_file(Path) ->
prune(ParsedFiles, RootApplicationModule) ->
case find_entrypoint(ParsedFiles) of
false ->
throw("No input beam files contain start/0 entrypoint");
throw({no_start_module_found, ParsedFiles});
{value, Entrypoint} ->
BeamFiles = lists:filter(fun is_beam/1, ParsedFiles),
Modules = closure(Entrypoint, BeamFiles, [get_element_module(Entrypoint)]),
Expand Down Expand Up @@ -524,14 +524,20 @@ remove(Module, ParsedFiles) ->

%% @private
get_imports(ParsedFile) ->
Imports = proplists:get_value(imports, proplists:get_value(chunk_refs, ParsedFile)),
Chunks = proplists:get_value(chunk_refs, ParsedFile, []),
Imports =
case proplists:get_value(imports, Chunks, []) of
missing_chunk -> [];
Imports0 -> Imports0
end,
lists:usort([M || {M, _F, _A} <- Imports]).

%% @private
get_atoms(ParsedFile) ->
Chunks = proplists:get_value(chunk_refs, ParsedFile, []),
AtomsT = [
Atom
|| {_Index, Atom} <- proplists:get_value(atoms, proplists:get_value(chunk_refs, ParsedFile))
|| {_Index, Atom} <- proplists:get_value(atoms, Chunks, [])
],
AtomsFromLiterals = get_atom_literals(proplists:get_value(uncompressed_literals, ParsedFile)),
lists:usort(AtomsT ++ AtomsFromLiterals).
Expand Down Expand Up @@ -582,7 +588,7 @@ get_parsed_file(Module, ParsedFiles) ->
{value, V} ->
V;
false ->
exit({module_not_found, Module, ParsedFiles})
throw({module_not_found, Module, ParsedFiles})
end.

%% @private
Expand Down Expand Up @@ -809,7 +815,10 @@ write_packbeam(OutputFilePath, ParsedFiles) ->
PackedData =
[<<?AVM_HEADER>> | [pack_data(ParsedFile) || ParsedFile <- ParsedFiles]] ++
[create_header(0, 0, <<"end">>)],
file:write_file(OutputFilePath, PackedData).
case file:write_file(OutputFilePath, PackedData) of
ok -> ok;
{error, Reason} -> {error, {write_failed, OutputFilePath, Reason}}
end.

%% @private
pack_data(ParsedFile) ->
Expand Down
Loading