atom_table: fix inverted rehash load-factor check - #2372
Open
pguyot wants to merge 1 commit into
Open
Conversation
pguyot
force-pushed
the
w29/atom-table-rehash-fix
branch
from
July 20, 2026 19:36
e1bfee4 to
4028aec
Compare
bettio
approved these changes
Jul 25, 2026
bettio
requested changes
Jul 25, 2026
bettio
left a comment
bettio
left a comment
Collaborator
There was a problem hiding this comment.
Wait, this PR fails to build on macOS.
Invert the condition: grow once the load factor would exceed the threshold. Add a test-structs regression test that bulk-inserts many atoms in batches and verifies each is retrievable by index and by name. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w29/atom-table-rehash-fix
branch
from
July 25, 2026 13:55
4028aec to
0d8ffe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invert the condition: grow once the load factor would exceed the threshold.
Add a test-structs regression test that bulk-inserts many atoms in batches and verifies each is retrievable by index and by name.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later