Conversation
partMatches compiled a Pattern on every call. Operation resolution compares a request against every API path in the matching bucket, so the compilations scaled with the size of the spec rather than the request. The pattern depends only on the API path template, which is fixed for the lifetime of the ApiPathImpl, so it is now compiled once in the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
partMatches compiled a Pattern on every call.
Operation resolution compares a request against every API path in the matching bucket, so the compilations scaled with the size of the spec rather than the request.
The pattern depends only on the API path template, which is fixed for the lifetime of the ApiPathImpl, so it is now compiled once in the constructor.
Context
While profiling a long running validation I noticed a large amount of samples within the partMatches method. Through investigation I found out that it was mostly because of GC pressure with another problem, but this patch by itself seemed worth it to me to submit nonetheless.
For me, it was about 380 KiB per request (very large open-api-spec).
I also added some baseline tests, since I am touching this part of the code. I verified that they pass before and after the change.