fix: print workspace package tags from publish:trusted - #2302
Open
princerajpoot20 wants to merge 5 commits into
Open
princerajpoot20 wants to merge 5 commits into
princerajpoot20 wants to merge 5 commits into
Conversation
princerajpoot20
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
September 20, 2026 06:21
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merge:
on npm,
@asyncapi/optimizerTrusted Publisher should be repoasyncapi/cliand workflowrelease-with-changesets.yml.Why
changesets/actionreads lines likeNew tag: @asyncapi/cli@6.2.0. That text used to live in an npm script inpackage.json. npm prints the script before it runs, so the action sawNew tag: $PACKAGE_NAME@...and crashed. The npm publish step never ran.This PR also sits on master after turbo was bumped 1 → 2. Turbo 2 needs a
packageManagerfield to see npm workspaces.What changed
scripts/publish-trusted.js. It prints oneNew tag:line per unpublished workspace package. npm publish is still the next workflow step (changeset publish)."packageManager": "npm@11.6.2"so turbo 2 can resolve workspaces.Related asyncapi/optimizer#306