add CASA, horizontal benchmark summary and get CI up and running again#89
Open
egpbos wants to merge 27 commits into
Open
add CASA, horizontal benchmark summary and get CI up and running again#89egpbos wants to merge 27 commits into
egpbos wants to merge 27 commits into
Conversation
It is causing too much issues, since it depends on a very old setuptools to install (due to the use_2to3 flag in setup.py) which clashes with the requirements of other packages.
Also simplify the workflow script.
Remove Kapteyn package references and related code
It was only necessary for kapteyn, which we just removed.
It was moved after astropy v6
Get running
The latest astropy was being installed from github, which is slow because it is not pre-built. Switched to the regular PyPI version.
I had changed it into a string.
The old one is failing on main. Cannot debug it from the PR, but let's put it in here already for after the merge.
…e-frame-transformations Add CASA.measures coordinate frame transformations benchmark tool
To make failures of this part or the other easier to spot in the GHA web env, this commit also splits the install step into two separate oneliner steps.
The AZEL frame was not the right one (topocentric), it seems, the AZELGEO (geodetic) frame is much closer to those in the other tools. Apart from that, a minor unit change and an added note to remind future maintainers to properly implement time for the horizontal comparison if that ever gets in.
It doesn't seem to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was mainly meant to introduce support for the CASA (radio astronomy) measures tool, which I needed for a project within the ALMA pipeline (we are considering converting from CASA to astropy coordinate transformations, but need to know the impact and possible mitigations, so this benchmark suite is a perfect starting point!). I included the functions needed for a horizontal benchmark, but since no horizontal summary page was yet available to conveniently do a sanity check, I also implemented the summary page. A preview of this is available at http://egpbos.nl/coordinates-benchmark/summary_horizontal.html. The rest of the deployment is also available there at http://egpbos.nl/coordinates-benchmark/summary.html
To get the benchmark running again at all, I had to remove support for the Kapteyn, PySLALIB, and PyTPM tools, since they are no longer being maintained and are leading to dependency clashes and crashes.
I also updated the benchmark workflow to use Python 3.11, updated/modernized the GitHub Actions, and updated the documentation to reflect the supported tools (though I didn't go through the docs thoroughly). Fixed an import for
angular_separationfrom astropy as well.Fixes #61, fixes #81 and closes #87.