Repository navigation
HEASARC: make remote heasarc test more robust against changing backend - #3696
Conversation
zoghbi-a
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3696 +/- ##
==========================================
+ Coverage 73.86% 73.87% +0.01%
==========================================
Files 228 228
Lines 21475 21485 +10
==========================================
+ Hits 15863 15873 +10
Misses 5612 5612 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| - Fix ``query_region`` for catalog=None. It should fail early. [#3630] | ||
| - Fix ``query_region`` when passing ``add_offset`` along with ``columns=None``. [#3630] | ||
| - Generalize the ``content-type`` filter in ``locate_data`` in anticipation for backend datalink descriptor changes. [#3656] | ||
| - Make the remote datalink test more robust against backend row number changes. [#3696] |
There was a problem hiding this comment.
no need for changelog entry for test/docs/internal changes
There was a problem hiding this comment.
do you want it removed?
There was a problem hiding this comment.
yeah, I'll remove that commit before merging this.
|
Apparently I cannot push to this branch, even though it looks like the edit from maintainers is allowed. |
|
I am not sure about the permissions. I haven't changed anything from my end compared to previous PRs. In any case, I removed the entry in the change log. |
|
Hmm, now it works, I don't know what was wrong yesterday. Anyway, thanks for the PR! |
Update one of the remote heasarc tests to be more robust against the dynamic row numbers in the backend.
Closes #3695.