Repository navigation
MAST: Get map of cloud URIs from MastMissions - #3690
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
+ Coverage 73.94% 74.00% +0.05%
==========================================
Files 228 228
Lines 21572 21640 +68
==========================================
+ Hits 15952 16015 +63
- Misses 5620 5625 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
88759c8 to
67008b5
Compare
| For example: {"productType": "SCIENCE", "extension"=["fits","jpg"]} | ||
| verbose : bool, optional | ||
| Default True. Whether to issue warnings if a product cannot be found in the cloud. | ||
| **criteria |
There was a problem hiding this comment.
There is minor inconsistency, mission is missing from the docstring and criteria is not in the signature (but afaik is not used in the code anyway)
0dd953d to
b3528ab
Compare
b3528ab to
2649917
Compare
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
After the rebase there is an actual real conflict with having a duplicated download_file method, which is in fact not a duplicate on the content level.
Could you please have a look at it and keep one or the other? Then we need to rerun the remote tests and merge this away.
|
Done! |
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Thank you. The RTD failure is unrelated and is due to the requests intersphinx being unavailable.
Added
MastMissions.get_cloud_uri_mapto map products to their corresponding cloud locations. Closely mirrors theObservations.get_cloud_urismethod.I included some pieces from other PRs in this one so that certain things would work, and that's why test coverage is a bit low. Those pieces have tests added for them in other PRs.