Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3639 +/- ##
==========================================
+ Coverage 74.04% 74.07% +0.02%
==========================================
Files 228 228
Lines 21649 21677 +28
==========================================
+ Hits 16031 16058 +27
- Misses 5618 5619 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hey Celia! This looks great (I've already reviewed this PR on a different branch in my repository). To get the two failing checks to pass, you need to add an entry to the For the docs build, you can find the warning on line 748 of the output. I think in this case, you need to add a second layer of backticks to the text it's highlighting in the function docstring. |
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
This needs a rebase as I see a lot of deprecations that have been fixed are popping up when testing.
Other than that, a few minor comments and this should be ready to go.
|
|
||
| return manifest | ||
|
|
||
| def get_product_urls(self, products, *, mrp_only=False, cloud_only=False, include_bucket=True, |
There was a problem hiding this comment.
maybe have uri in the name rather than url so we will be more self consistent (e.g. with the other open PR that adds get_cloud_uris
There was a problem hiding this comment.
I will defer to @snbianco on this decision -- happy to implement whatever meshes well with any changes
| For convenience, `~astroquery.mast.ObservationsClass.get_product_urls` supports the same filtering options as | ||
| `~astroquery.mast.ObservationsClass.filter_products`, allowing users to retrieve URLs for only a selected subset of products. | ||
|
|
||
| .. doctest-skip:: |
There was a problem hiding this comment.
Please don't skip code examples, or provide a reasoning for it (preferably in a comment so our future self will know about it, too)
There was a problem hiding this comment.
Oops! I originally copied the example block styling from elsewhere, which included skip
2532c02 to
7e1caf0
Compare
Adds a MAST Observation method (
get_product_urls) that returns a list of URLs for products without downloading them. This addresses #2850. These changes have been reviewed/guided by @snbianco, and I am looking forward to feedback!