Repository navigation
Drop the redundant "(the encrypted vault)" from local env messages - #2298
Merged
Merged
Conversation
A vault set printed "set connection x in vault (the encrypted vault)". Encrypted is the default, so the parenthetical only repeated the scope. The vault writer's Location is now empty when encrypted and "unencrypted" for --plain, and messages add the parenthetical only when there is one, so a .env store still names its path. Co-Authored-By: Claude <noreply@anthropic.com>
A --plain global set read "vault (global) (unencrypted)". A scope that already ends in a parenthetical now takes the location inside it: "vault (global, unencrypted)". Co-Authored-By: Claude <noreply@anthropic.com>
Coverage Report for CI Build 38187222111Coverage increased (+0.02%) to 57.69%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Review follow-ups: - A --plain delete of an encrypted global said "vault (global, unencrypted)": the mark followed the flag, which a delete carries too. The writer now marks itself unencrypted only after it stores a value plain. - storeWhere spliced the qualifier in by checking for a trailing ")". Each store now names itself with Where(), so nothing parses a label. - Location() meant a path for .env and a qualifier for the vault. It is gone; the one message that wanted the plaintext path uses DotenvPath. - Tests cover the printed text for each store and the plain mark. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A vault set printed
set connection x in vault (the encrypted vault). Encrypted is the default, so the parenthetical only repeated the scope.Each store now names itself for messages with
Where():vault/vault (global), andvault (global, unencrypted)only after the writer actually stored a value plain — a--plaindelete no longer calls an encrypted value unencrypted;.env:project (<path>).Location(), which meant a path for one store and a qualifier for the other, is gone; the one message that wanted the plaintext path usesDotenvPath(). Tests cover the printed text for each store.Text output only;
--output jsonis unchanged.