Use the same libffi version for musl builds - #1227
Merged
Merged
Conversation
jjhelmus
added
platform:darwin
libffi's static trampoline code includes Linux headers for PATH_MAX. Use the standard limits.h header instead so libffi can build with musl without Linux headers
jjhelmus
force-pushed
the
jjh/upgrade_libffi_for_musl
branch
from
August 20, 2026 16:58
55ca3f4 to
18c848d
Compare
EliteTK
approved these changes
Aug 20, 2026
EliteTK
left a comment
EliteTK
left a comment
Member
There was a problem hiding this comment.
Deleting code! Yay!
But also, I am curious, why don't we just include the linux headers for musl builds?
Contributor
Author
The headers from the base Debian image are available and used for glibc builds but the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the same libffi version for musl builds by patching libffi so that PATH_MAX is provided by the libc limits.h rather than the Linux kernel linux/limits.h.
Remove the unused libffi-3.3 package.
closes #814