Repository navigation
Conversation
Block SIGINT during PID attachment and pending-signal forwarding. Add a regression test and install util-linux for macOS CI session coverage. Co-Authored-By: Codex Desktop 26.1007.21159 (runtime codex-cli 0.162.0-alpha.17.2) / gpt-6-astra <codex@openai.com> Codex-Reasoning-Effort: low
asmacdo
pushed a commit
that referenced
this pull request
Oct 12, 2026
A SIGINT that arrived between attach() setting self.pid and checking sigcount was forwarded twice: once by the handler, which already saw the pid, and once more by attach() acting on the now nonzero count. The command got two SIGINTs for one Ctrl-C. With SIGINT blocked in the main thread (and in every helper thread, via start_thread), a signal in that window stays pending and is handled once, after the mask is restored. Split out of #2, which also enabled setsid on macOS CI. Co-Authored-By: Claude Code 2.1.296 / Claude Opus 5.5 <noreply@anthropic.com>
asmacdo
pushed a commit
that referenced
this pull request
Oct 12, 2026
macOS has no setsid command, so the setsid cases of test_spawn_children were skipped on the macOS jobs. Homebrew's util-linux provides it; it is keg-only, so put its bin on PATH. Split out of #2, which also fixed a double-forwarded SIGINT in attach(). Co-Authored-By: Claude Code 2.1.296 / Claude Opus 5.5 <noreply@anthropic.com>
asmacdo
pushed a commit
that referenced
this pull request
Oct 12, 2026
A SIGINT that arrived between attach() setting self.pid and checking sigcount was forwarded twice: once by the handler, which already saw the pid, and once more by attach() acting on the now nonzero count. The command got two SIGINTs for one Ctrl-C. With SIGINT blocked in the main thread (and in every helper thread, via start_thread), a signal in that window stays pending and is handled once, after the mask is restored. Split out of #2, which also enabled setsid on macOS CI. Co-Authored-By: Codex Desktop 26.1007.21159 (runtime codex-cli 0.162.0-alpha.17.2) / gpt-6-astra <codex@openai.com> Codex-Reasoning-Effort: low Co-Authored-By: Claude Code 2.1.296 / Claude Opus 5.5 <noreply@anthropic.com>
asmacdo
pushed a commit
that referenced
this pull request
Oct 12, 2026
macOS has no setsid command, so the setsid cases of test_spawn_children were skipped on the macOS jobs. Homebrew's util-linux provides it; it is keg-only, so put its bin on PATH. Split out of #2, which also fixed a double-forwarded SIGINT in attach(). Co-Authored-By: Codex Desktop 26.1007.21159 (runtime codex-cli 0.162.0-alpha.17.2) / gpt-6-astra <codex@openai.com> Codex-Reasoning-Effort: low Co-Authored-By: Claude Code 2.1.296 / Claude Opus 5.5 <noreply@anthropic.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated draft — not reviewed by John
Two small follow-ups to con#456:
util-linuxon macOS CI and add its bin directory to PATH forsetsidcoverage.Validation: the regression fails before the fix; all 24 signal tests pass on this base. All pre-commit checks pass. With con#457's changes, 74 affected tests and all six previously skipped
setsidcases pass locally.The combined con#456 and con#457 changes already pass upstream CI; con#456's standalone Intel Mac sampling failure is addressed by con#457.