Repository navigation
fix: qualify real PostgreSQL generation and validation - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shipped PostgreSQL generation/validation workflow stops at a reset stub, returns identity rows instead of schema snapshots, and generates no result columns. This change completes the scratch workflow and verifies it against real and normally installed PostgreSQL adapters.
Scratch reset first proves actual database separation with database-local advisory locks while the target is pinned in a read-only transaction. The scratch adapter owns a serialized physical session and a workflow lock through reset, replay, rollback-only desired-DDL normalization, diff and query description. Native catalog comparison preserves physical facts; application properties/codecs stay in source identity, and only explicitly declared constraint/index names participate in name equality. Unsupported schema shapes fail with corrective errors. Reset's destructive scope and the direct/session-pool requirement are documented.
Query metadata uses protocol Parse/Describe/Sync and never Bind/Execute. Multi-command input is rejected before any command runs. Result nullability is conservative; generated types match standard pg parsers or remain unknown. Repeated named parameters produce one generated property while retaining positional bindings, and duplicate output column names require aliases. Native tests also exposed and fixed quoted enum identifiers, composite primary keys, related-table creation order and unique-column rename/no-op behavior.
Validation:
Closes #55. Refs #53 and #54; those remain open for the coordinated 0.5.0 candidate and generated website qualification. No version bump, tag, GitHub release or npm publication is included. The maintainer's full review and approval of the final coordinated candidate remain required before official publication.