Repository navigation
Contract Node exports and harden transport cleanup for 0.5 - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node can retain transport resources after startup/write failure, and pending MCP stream errors can terminate the process after shutdown. This fixes ten reproduced ownership/ordering defects, including stalled cancellation, rejected response headers, late responses, pending authentication and partial setup. Application cancellation is best-effort; native startup errors retain their identity.
For the 0.5.0 API review, replace wildcard root exports with 10 deliberate contracts (13 including MCP), down from 16. Remove
normalizeClientAddress,ConnectNextandNodeWebSocketOptions, with a complete inventory and compiled replacements indocs/0.5.0-api.md. Migrate router imports and the obsolete README example before Server's API contraction.Validation on Node 24.21.0:
npm ci, format, lint, strict source/test/benchmark types, 106 tests, V8 source floors, build, publint and package file checks.docs/0.5.0-hardening.md.Self-review inspected source, assertion bodies, failure recovery, stream/listener ownership and the installed declaration surface. This is not an independent-agent review. Versions remain 0.4.x preparation versions. No tags or packages are published; the full coordinated candidate requires the maintainer's review and explicit approval.
Closes #51. Refs #50; API issue remains open for the final cross-package graph and website migration.