ci: Redline review as a CI check - #86
Merged
Merged
Conversation
Calls askalf/askalf's redline-review.yml (pinned) on the redline runner for same-repo, non-draft PRs. fleet-status refreshes when Redline finishes.
askalf
marked this pull request as ready for review
September 25, 2026 18:24
askalf
enabled auto-merge (squash)
September 25, 2026 18:26
sprayberry-redline
approved these changes
Sep 25, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Automated review from the Sprayberry Labs fleet code reviewer.
Reviewed by the gating lane (gating review).
Verdict: approve. No blocking findings at head b2ddda00609deb99cb5d3bf32347162800f96936.
What I checked:
- Exemption and CI. Both changed files are workflow configuration under
.github/workflows/(no script extension, nothing underactions/orscripts/), so the PR is exempt from Breaker verification.gh pr checks 86 --requiredat the live head:analyze (javascript-typescript),docker-buildandtestall pass; the only pending context isfleet/review, which is this review. - Pin.
uses: askalf/askalf/.github/workflows/redline-review.yml@63e007ee5f514a32fbdaebaa313eacc5c44f852f(.github/workflows/redline.yml:23). I resolved that SHA myself: it is the merge commit of askalf/askalf#60 andcompare/main...63e007eereportsidentical, so the commentmain 2026-09-25, askalf/askalf#60is accurate. - Callee contract. The called workflow declares a single required
workflow_callinput,runner-label(string), and this caller passes exactly that (runner-label: redline). The caller'spermissions(contents: read,pull-requests: read) match the callee's declared permissions, so the reusable workflow is not asking for more than the caller grants. - Guards. The job-level
if(draft == false && head.repo.full_name == github.repository, line 20) duplicates the callee's own same-repo/non-draft guard, as the comment says;ready_for_reviewis in the trigger types so a draft that is marked ready gets its first run. Theconcurrencygroup is keyed on the PR number withcancel-in-progress: true, matching the body's "a newer push cancels the older run". - fleet-status hookup.
workflow_run.workflowsgainsRedline(fleet-status.yml:18), which is exactly the new workflow'sname:; the existingworkflow_runjob filter already restricts to same-repopull_requestruns, so nothing else needed changing. - Precedent. The new file is identical to askalf/dario's
.github/workflows/redline.ymlexcept for the runner label, as the body claims. - Tell pass. No em dashes, filler or patch narration in the workflow comments, commit message, PR title or body.
Notes for the operator (non-blocking):
- Until the
redlineself-hosted runner is registered for this repo, any run of theRedlineworkflow will sit queued rather than fail, andfleet-statuswill not receive itsworkflow_run: completedevent. IfRedlineis later added to the branch's required checks, do that only after the runner is confirmed online, or same-repo PRs will block on a check that cannot start.
I did not run anything locally; CI is the test signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redline moves into this repo's CI, the way askalf/dario#1423 did.
.github/workflows/redline.ymlcalls askalf/askalf'sredline-review.yml, pinned to askalf/askalf#60, on theredlineself-hosted runner, for same-repo PRs that are not drafts. A newer push cancels the older run for the same PR.Where fleet-status lists the workflows that refresh it,
Redlineis added, and the fleet-status tests pass.Draft until this repo's
redlinerunner is registered on the host; marking it ready is the first live run.