fleet-status: drop the retired Second Read lane - #85
Merged
Merged
Conversation
fleet/second-read is no longer required and nothing posts it; the script posts fleet/verify and fleet/review only.
sprayberry-redline
approved these changes
Sep 25, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Automated review from the Sprayberry Labs fleet code reviewer.
Reviewed by the gating lane (gating review).
Verdict: approve. No blocking findings at head 4e74c00.
What I checked:
- The diff is a pure removal:
SECOND_READ_LOGIN,secondReadAtHead, thefleet/second-readentry inCONTEXTS, and the thirdout.pushblock inlaneStatusesare gone fromscripts/fleet-status.mjs, and every test that depended on them is dropped fromscripts/fleet-status.test.mjs. Nothing is added except a header-comment count change ("three" to "two"). - At the head,
grep -i secondoverscripts/fleet-status.mjs,scripts/fleet-status.test.mjs,.github/workflows/fleet-status.yml,README.mdand the docs tree returns nothing, so no caller of the removed exports remains. OWN_CONTEXTS = new Set(Object.values(CONTEXTS))(line 22) now holds exactlyfleet/verifyandfleet/review, which is what the self-exclusion testown lanes required, three rounds: both greenasserts. The test's own-lanes list was updated in lockstep (const own = [CONTEXTS.verify, CONTEXTS.review]).- The
a missing context is postedassertion inscripts/fleet-status.test.mjs:252was re-pointed at a syntheticfleet/newcontext rather than deleted, sostatusesToPoststill has coverage for the missing-context branch. - The verify and review lanes' predicates (
code,verified,gated,rv.commitId === facts.head) are untouched; the removed block was a leaf that read them, not something they read. - Required checks
test,analyze (javascript-typescript)anddocker-buildall pass at4e74c00. - Tell pass over the title, body, commit message, code and test: no em dashes, no patch narration, no filler. The commit body states the fact plainly.
Minor, non-blocking: the removal leaves two consecutive blank lines before return out.map(...) in laneStatuses (scripts/fleet-status.mjs:175-176). Harmless; a linter would fold it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Second Read has been retired: operator decision, 2026-09-25.
fleet/second-readis no longer a required check on any repo, and nothing posts a verdict for it anymore, so this lane would sit at pending forever.scripts/fleet-status.mjsnow posts onlyfleet/verifyandfleet/review.SECOND_READ_LOGIN,secondReadAtHeadand thefleet/second-readlane are gone.The remaining fleet-status tests all pass locally with no Second Read references left in the script or its test.