fix(companion): rollback session when POST /sessions fails after create - #14
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(companion): rollback session when POST /sessions fails after create#14cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
createSession could leave orphaned browser contexts when response validation or serialization failed after the runtime session was created. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
POST /sessionscould leave orphaned Chromium browser contexts whencreateSession()succeeded but response validation or serialization failed afterward. Retries accumulated live contexts with nosessionIdreturned to the client.Root cause
The companion handler had no compensating
closeSessionwhen errors occurred after runtime session creation.Fix
Track
createdSessionIdand callruntime.closeSession()in the error path before returning the failure response.Validation
pnpm --filter @webchain/companion test— 14 tests pass, including new rollback test.