fix(runtime): recover from dead browser without companion restart - #10
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(runtime): recover from dead browser without companion restart#10cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Reset the cached browser promise when Chromium disconnects or newContext fails on a closed browser, clear stale sessions, and retry once so createSession works again in a long-running companion daemon. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
After Chromium crashes or is killed, the companion daemon caches a dead
Browserhandle forever. Every subsequentcreateSession()fails with "Target page, context or browser has been closed" until the process is restarted.Root cause
browserPromisewas only cleared on launch failure, not when the browser disconnects ornewContext()fails on a closed browser.Fix and validation
disconnectedevents and invalidate cached browser state.createSession()once after resetting state whennewContext()fails on a closed browser.Validation
pnpm --filter @webchain/runtime test— 27 tests passed (including 2 new recovery tests).