fix(cron): defer job commit until agent delivery succeeds - #57
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(cron): defer job commit until agent delivery succeeds#57cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
One-shot and recurring cron jobs were deleted or rescheduled in cron_poll before the message was handed to the agent, causing permanent data loss when allocation or dispatch failed. Ack delivery only after successful agent_run. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
One-shot and recurring cron jobs were deleted or rescheduled inside
cron_poll()before the message reached the agent. Ifstrdupfailed oragent_runfailed, scheduled reminders were permanently lost.Root cause
cron_poll()mutated the SQLite cron_jobs table (delete for one-shot, update next_run for recurring) before building the channel message and beforehandle_message()ran.Fix
-1on allocation failure without touching the DB.cron_ack_delivery()to delete one-shot jobs or advance recurring schedules only after successful agent delivery.cron_ack_delivery()fromdispatch.cwhen the cron channel completes a successfulagent_run+ send.Validation
./build/test_cron— all tests pass, including new coverage for deferred ack and poll-without-commit.