test: reject Discord route edge cases in helpers - #55
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Cover null payload, bot authors, empty author ids, and guild messages without a bot user id so allowlist gating cannot silently widen. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends Discord helper routing tests with negative cases for allowlist/mention gating without touching the production gateway parser.
Risky behavior now covered
-1bot_user_idskipped (mention gate cannot widen)Test files added/updated
tests/test_discord_helpers.cWhy these tests materially reduce regression risk
These pure helpers encode the Discord allowlist/bot/mention policy surface. Happy-path fixtures alone would miss regressions that accidentally accept bot traffic or guild traffic without bot identity.
How Has This Been Tested?
make test_discord_helpers+./build/test_discord_helpers(all tests passed)Note
Full Discord gateway (
discord.c) production parser coverage still deferred — needs dedicated-DSHELLCLAW_TESTseams.