test(proxy): cover CSP, CORS origin gate, rate-limit IP, and auth guard - #20
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(proxy): cover CSP, CORS origin gate, rate-limit IP, and auth guard#20cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for proxy security layer, client IP resolution, and production auth bypass prevention introduced in PR #15. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
src/proxy.ts): rejects cross-origin API requests outside allowlist, blocks origin prefix spoofing (app.example.com.attacker.com), allows configured self-origin and localhost in dev, sets CSP nonce headers, handles OPTIONS preflight.src/lib/rate-limit-client-ip.ts): pinned trusted header, comma-split fallback, x-forwarded-for/x-real-ip chain, anonymous fallback.src/auth.ts): mock session never activates whenNODE_ENV=production, even withPLAYWRIGHT_E2E=1.Test files added/updated
tests/lib/proxy.test.ts(new)tests/lib/rate-limit-client-ip.test.ts(new)tests/lib/auth.test.ts(new)Why these tests materially reduce regression risk
PR #15 hardened CSP, proxy CORS, OAuth PKCE, and auth bypass guards but only
isE2ERateLimitBypasshad unit coverage. These tests lock down the security-critical proxy and auth paths that protect API routes from cross-origin abuse and accidental production auth bypass.Validation
14 tests passed.