test(oauth): cover connector-store lifecycle and OAuth route handlers - #19
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(oauth): cover connector-store lifecycle and OAuth route handlers#19cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for PKCE cookie flags, connector status transitions, and authorize/callback/refresh HTTP boundaries from PR #15 OAuth hardening. Co-authored-by: esadrianno <esadrianno@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for OAuth and connector lifecycle from PR #15 (design system + OAuth/CSP hardening).
Risky behavior now covered
Test files added/updated
tests/lib/connector-store.test.ts(new, 5 tests)tests/api/oauth-routes.test.ts(new, 9 tests)tests/lib/oauth-manager.test.ts(+3 tests)Why these tests materially reduce regression risk
Lib-level PKCE tests did not cover HTTP route boundaries (cookie set/clear, redirects, auth gates). Connector-store mutations drive UI status; untested delete logic could leave connectors stuck in wrong states.
How tested
21/21 passed.