Surgical Django cache purge - #609
Open
skaphan wants to merge 3 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| with open(filenames.ONE_ROUND, 'r', encoding='utf-8') as f: | ||
| self.client.post('/upload.html', {'jsonFile': f}) | ||
| config = TestHelpers.get_latest_upload() | ||
| path = reverse('visualize', args=(config.slug,)) |
Check notice
Code scanning / CodeQL
Unused local variable Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 days ago
The safest fix is to remove the unused assignment while preserving behavior.
- General approach: if a variable is assigned and never used, delete the assignment unless the right-hand side has required side effects.
- Here:
reverse('visualize', args=(config.slug,))is side-effect free in this context, and the resultingpathis unused, so remove that line. - File/region:
visualizer/tests/testSimple.py, insidetest_purge_django_cache_tries_www_variant, remove line withpath = .... - No imports/methods/definitions are needed.
Suggested changeset
1
visualizer/tests/testSimple.py
| @@ -731,7 +731,6 @@ | ||
| with open(filenames.ONE_ROUND, 'r', encoding='utf-8') as f: | ||
| self.client.post('/upload.html', {'jsonFile': f}) | ||
| config = TestHelpers.get_latest_upload() | ||
| path = reverse('visualize', args=(config.slug,)) | ||
|
|
||
| # _get_purge_domains should include both example.com and www.example.com | ||
| domains = CloudflareAPI._get_purge_domains() |
Copilot is powered by AI and may make mistakes. Always verify output.
skaphan
force-pushed
the
surgical-cache-purge
branch
from
March 20, 2026 19:23
7029d2a to
9916f83
Compare
skaphan
force-pushed
the
surgical-cache-purge
branch
from
April 8, 2026 02:05
9916f83 to
993bb17
Compare
Co-Authored-By: Claude Opus 4.6
Uses thread-local middleware to capture the current request host, then builds synthetic requests matching each cached URL to delete only the affected cache entries instead of clearing everything. Co-Authored-By: Claude Opus 4.6
Replace temporary ALLOWED_HOSTS mutation with DisallowedHost catch-and-skip to avoid modifying security settings at runtime. Replace two separate purge tests with one comprehensive test that verifies purge_vis_cache clears all cached URL variants for a slug, including query-string variants. Co-Authored-By: Claude Opus 4.6
skaphan
force-pushed
the
surgical-cache-purge
branch
from
April 10, 2026 16:56
993bb17 to
1675b64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up optimization to #608. This is a nice-to-have, not critical — #608's cache.clear() is correct and safe.
Test plan
🤖 Generated with Claude Code