Rrivera/better common context table handling#424
Open
rrivera747 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves “Context Common” table state reporting/handling in GatewaySupervisor by making the tracked “last applied” Context Common lists thread-safe, resetting them on configuration activation, and exposing them in the state-machine status XML. It also updates the Desktop Icon table metadata to include an icon option for the FE Macro Test UI.
Changes:
- Reset
appliedContextCommonList_/appliedContextCommonOverrideList_undercontextCommonMutex_after configuration activation to avoid stale applied-state. - Include the applied Context Common lists in
addStateMachineStatusToXML()output (under mutex protection) to surface them in status polling. - Add
icon-FEMacroTest.pngas an allowedImageURLchoice inDesktopIconTableInfo.xml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| otsdaq/GatewaySupervisor/GatewaySupervisor.cc | Adds mutex-protected reset and status XML reporting for applied Context Common table lists. |
| data-core/TableInfo/ContextGroup/DesktopIconTableInfo.xml | Extends Desktop icon image choices to include FE Macro Test icon. |
eflumerf
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.