Add tracing instrumentation for prover stages#53
Merged
Conversation
samuelburnham
requested review from
arthurpaulino and
gabriel-barrett
and removed request for
arthurpaulino
Emit `tracing` spans for each major STARK proving stage in `System::prove_multiple_claims`: stage 1 commit, lookup construction, stage 2 commit, quotient, and FRI opening. Lookup trace construction itself is broken into `lookup_messages`, `batch_inverse`, and `lookup_traces` sub-spans. The whole call is wrapped in `stark/prove` via `#[tracing::instrument]`. No subscriber is installed here — downstream consumers wire up a subscriber (e.g. `tracing-texray`) to consume the spans.
samuelburnham
force-pushed
the
sb/streaming-print
branch
from
dbe77db to
b156cf9
Compare
arthurpaulino
approved these changes
May 14, 2026
Member
arthurpaulino
left a comment
arthurpaulino
left a comment
There was a problem hiding this comment.
I'm often unsure whether tracing instrumentation should live in the main branch. But we can decide that later. For now, this will help us a lot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tracing instrumentation for profiling proof generation. If there is no subscriber initialized then the overhead is negligible, but applications can add subscribers like tracing-texray to collect and display the output.