Make firmware updater and address changer more robust - #77
Open
sebromero wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the logic for scanning Modulinos into its separate class to be used by the firmware updater and the address changer sketch. Also the list of Modulinos with their default addresses etc. is now maintained in one single file. Adding new Modulinos will be easier that way.
The firmware updater sketch now correctly handles devices that are stuck in bootloader mode. Also, it asks the user if they want to start flashing which avoids an issue that some people had who unplugged their board halfway when flashing which bricked the modules. It also features a nicer interactive mode to select the Modulino to be flashed.