Skip to content

fix(tui): avoid NoMatches exception when SelectionList is missing on key events. #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrshtmk wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

fix(tui): avoid NoMatches exception when SelectionList is missing on key events. #4780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123bfe3
fix(tui): avoid NoMatches exception when SelectionList is missing on …
hrshtmk Sep 20, 2026
ff847a8
Merge branch 'archlinux:master' into fix/select-list-crash
hrshtmk Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions archinstall/tui/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,9 +567,9 @@ def on_mount(self) -> None:
self.query_one(SelectionList).focus()

def on_key(self, event: Key) -> None:
selection_list = self.query_one(SelectionList)

if not selection_list.has_focus or event.key != 'enter':
# Safely query SelectionList to avoid NoMatches crashes during screen transitions or key events.
selection_list = self.query(SelectionList).first()
if not selection_list or not selection_list.has_focus or event.key != 'enter':
return

if len(self._selected_items) < 1:
Expand Down