Skip to content

Remove superfluous PacmanConfiguration.default #4682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Jul 31, 2026
+4 −8
Merged

Remove superfluous PacmanConfiguration.default #4682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archinstall/lib/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ class ArchConfig:
kernels: list[str] = field(default_factory=lambda: [DEFAULT_KERNEL.value])
ntp: bool = True
packages: list[str] = field(default_factory=list)
pacman_config: PacmanConfiguration = field(default_factory=PacmanConfiguration.default)
pacman_config: PacmanConfiguration = field(default_factory=PacmanConfiguration)
timezone: str = 'UTC'
services: list[str] = field(default_factory=list)
custom_commands: list[str] = field(default_factory=list)
Expand Down
2 changes: 1 addition & 1 deletion archinstall/lib/global_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def _get_menu_options(self) -> list[MenuItem]:
MenuItem(
text=tr('Pacman'),
action=self._pacman_configuration,
value=PacmanConfiguration.default(),
value=PacmanConfiguration(),
preview_action=self._prev_pacman_config,
key='pacman_config',
),
Expand Down
6 changes: 1 addition & 5 deletions archinstall/lib/models/pacman.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ class PacmanConfiguration(SubConfig):
parallel_downloads: int = 5
color: bool = True

@classmethod
def default(cls) -> Self:
return cls()

@override
def json(self) -> PacmanConfigSerialization:
return {
Expand All @@ -40,7 +36,7 @@ def preview(self) -> str:

@classmethod
def parse_arg(cls, args: PacmanConfigSerialization) -> Self:
config = cls.default()
config = cls()

if 'parallel_downloads' in args:
config.parallel_downloads = int(args['parallel_downloads'])
Expand Down
2 changes: 1 addition & 1 deletion archinstall/lib/pacman/pacman_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async def show(self) -> PacmanConfiguration | None:
config = await super().show()

if config is None:
return PacmanConfiguration.default()
return PacmanConfiguration()

_apply_to_live(config.parallel_downloads)

Expand Down