Skip to content

Add some convenient constructors for NumMatrix and NumVector - #2784

Merged
grospelliergilles merged 1 commit into
mainfrom
dev/gg-add-converter-for-nummatrix-and-numvector
Sep 26, 2026
Merged

grospelliergilles merged 1 commit into
mainfrom
dev/gg-add-converter-for-nummatrix-and-numvector

Conversation

@grospelliergilles

Copy link
Copy Markdown
Member
  • Allow conversion from NumVector to a NumMatrix with one row.
  • Allow implicit conversion from std::array and T[N] to NumVector.

…NumVector'.

- Allow conversion from 'NumVector' to a 'NumMatrix' with one row.
- Allow implicit conversion from 'std::array' and 'T[N]' to 'NumVector'.
@grospelliergilles grospelliergilles self-assigned this Sep 26, 2026
@grospelliergilles grospelliergilles added arccore Arccore component refactoring Code refactoring and cleanup labels Sep 26, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.58%. Comparing base (bbf244b) to head (0b131a3).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arccore/src/base/arccore/base/NumMatrix.h 0.00% 3 Missing ⚠️
arccore/src/base/arccore/base/NumVector.h 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2784      +/-   ##
==========================================
+ Coverage   71.56%   71.58%   +0.01%     
==========================================
  Files        2565     2565              
  Lines      194005   194008       +3     
  Branches    23032    23032              
==========================================
+ Hits       138847   138887      +40     
+ Misses      46569    46532      -37     
  Partials     8589     8589              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grospelliergilles
grospelliergilles merged commit 23e00e1 into main Sep 26, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arccore Arccore component refactoring Code refactoring and cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant