release: v2.3.3 - #968
Merged
Merged
Conversation
…target Without antState, the SDK defaults the @ record's transactionId to ARIO_LOGO_TX_ID (the ar.io logo image). By passing createAntStateForOwner() — which sets transactionId to LANDING_PAGE_TXID — newly purchased names resolve to the proper landing page instead of the logo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: pass antState to atomic buyRecord so new names use landing page target
…ss guessing (#965) The TurboArNSClient was detecting token type by inspecting the wallet address format. When the address was undefined or detection failed, it defaulted to 'arweave', causing 404s on the Turbo payment service for Solana users. Now accepts an explicit tokenType from the wallet connector. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…ntire registry (#967) * fix: use single-record lookup in useDomainInfo instead of scanning entire registry useDomainInfo was calling getArNSRecords (plural) with no effective filter, which fetches and deserializes every ArNS record on-chain (~4k+ accounts) just to find one by name. Replace with getArNSRecord (singular) — a single PDA read — and parallelize ANT state + write- instance initialization via Promise.all. Associated names now use a filtered getArNSRecords call with the real processId, which hits the efficient memcmp path instead of scanning. Also adds 'arns-record' (singular) cache key to invalidation predicates in DomainSettings and dispatchArIOInteraction so the new cache entries are properly busted after transactions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: include arns-record in useDomainInfo refetch invalidation The refetch helper invalidates cached queries by key name, but was missing the new 'arns-record' (singular) key used by the optimized single-record lookup. Without this, manual refetch would return stale record data from the nested fetchQuery. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address CodeRabbit findings on useDomainInfo - Remove catch-all `.catch(() => null)` on record lookup so real SDK/RPC errors propagate instead of being silently swallowed - Include lowerCaseDomain(domain) in refetch invalidation keyVals so the arns-record cache key (which uses the normalized name) is properly busted Skipped: emitting ANTStateError via eventEmitter — the original code also didn't emit; errors surface through DomainInfo.errors to the UI already. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenTypeexplicitly instead of address-format guessingbuyRecorddefaulting@record target to ar.io logo instead of landing page — now passesantStatewithLANDING_PAGE_TXIDTest plan
🤖 Generated with Claude Code