Repository navigation
check for IsMultithreadedApplication, add guard for no SD code attached - #712
Merged
SeverinDiederichs merged 1 commit intoOct 22, 2026
Conversation
Collaborator
Author
|
@codex review |
Collaborator
Author
|
/run-test |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug that was observed with CMSSW:
AdePT was incorrectly constructed on the master thread, which had no SD codes attached. Therefore, the AdePT kernels ignored all hits in the SD code which were solely due to the energy deposition. Still, a very large number of hits was returned, as e.g., all first and last steps of particles were returned (and on the worker thread the SD code was available), thus the scoring happened by accident.
The problem was that the guard:
Did not fire, as the
GetMasterRunManageris a nullptr in CMSSW, despite being an MT application, due to their custom run manager. Therefore, the correct check is:G4Threading::IsMultithreadedApplication()A defensive check is added to warn when no SD code is attached at all.
Now, the total energy deposition in CMSSW looks much better:
Assisted-by: Claude Code (Claude Fable 5)