Repository navigation
feat: advertise WAF tools to API-key sessions - #128
Merged
Merged
Conversation
The WAF rule endpoints accept project API keys (wafRules.read and wafRules.write), but waf was missing from the API-key allowlist, so local API-key sessions never listed its tools. Also applies ruff format to server.py.
🟢 Tier S · Ready to merge
Adds the WAF service to the API-key catalog, making its tools available to API-key sessions. Updates catalog coverage assertions for the additional service and tools, and reformats two lambdas in
📂 Walkthrough · 3
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WAF rule endpoints accept project API keys through the
wafRules.readandwafRules.writescopes, butwafwas missing fromAPI_KEY_SERVICES, so API-key sessions never listed its 13 tools. Hosted OAuth sessions already list them.Also runs
ruff formatonserver.py, whichmainhad left unformatted.Until
appwrite-console0.9.0 ships, the WAF create/update tools typeconditionsas a string, because the spec declared it that way. appwrite/appwrite#14265 fixes the spec, and the console SDK pin bump will follow.