Skip to content

feat: advertise WAF tools to API-key sessions - #128

Merged
ChiragAgg5k merged 1 commit into
mainfrom
feat/api-key-waf
Oct 8, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
feat/api-key-waf

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

The WAF rule endpoints accept project API keys through the wafRules.read and wafRules.write scopes, but waf was missing from API_KEY_SERVICES, so API-key sessions never listed its 13 tools. Hosted OAuth sessions already list them.

Also runs ruff format on server.py, which main had left unformatted.

Until appwrite-console 0.9.0 ships, the WAF create/update tools type conditions as a string, because the spec declared it that way. appwrite/appwrite#14265 fixes the spec, and the console SDK pin bump will follow.

The WAF rule endpoints accept project API keys (wafRules.read and wafRules.write), but waf was missing from the API-key allowlist, so local API-key sessions never listed its tools. Also applies ruff format to server.py.
@hansi-codes

hansi-codes Bot commented Oct 8, 2026

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The WAF service is already classified as project-scoped, and the catalog change is consistent with the stated API-key support.

Adds the WAF service to the API-key catalog, making its tools available to API-key sessions. Updates catalog coverage assertions for the additional service and tools, and reformats two lambdas in server.py.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 3
File Change
src/mcp_server_appwrite/catalog_policy.py Includes WAF among the services advertised to API-key sessions.
src/mcp_server_appwrite/server.py Reformats existing lambdas without changing their behavior.
tests/unit/test_server.py Updates API-key catalog counts and asserts WAF tools are present.

Reviewed 6d6ee00 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit 8214540 into main Oct 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant