Skip to content

chore(docker): build the image on the toolchain the shared crates need - #161

Open
abnegate wants to merge 1 commit into
mainfrom
ws-claudear
Open

abnegate wants to merge 1 commit into
mainfrom
ws-claudear

Conversation

@abnegate

Copy link
Copy Markdown
Member

Summary

  • The shared abnegate crates now require Rust 1.98, so the release image's builder stage moves from rust:1.93 to rust:1.98 (ARG RUST_VERSION).
  • The documented minimum toolchain follows: README badge and prerequisites, website/docs/development.html, and the docs search index.

CI workflows already use dtolnay/rust-toolchain@stable, so only the Docker image and docs pinned 1.93.

Test plan

  • docker build --target builder . (rustc 1.98.1 in the builder)
  • docker build .; claudear --version runs in the final image
  • git grep '1\.93' is empty

🤖 Generated with Claude Code

@hansi-codes

hansi-codes Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The version updates are consistent across the builder and documentation, with no issues found.

The Docker builder now uses Rust 1.98, and the documented minimum Rust version is updated to match. The README, development guide, and docs search index all reflect the new version.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 4
File Change
Dockerfile Raised the default Rust version used by the Docker builder to 1.98.
README.md Updated the Rust version badge and prerequisites.
website/docs/development.html Updated the development guide's Rust prerequisite.
website/docs/assets/docs-search-index.js Updated the indexed prerequisite text.

Reviewed 54ff4d7 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Bumps the minimum Rust toolchain version.

The PR appears safe to merge; no actionable issue was identified.

Summary

The PR updates the Docker builder from Rust 1.93 to 1.98 and aligns the README, development page, and documentation search index with that minimum.

Reviews (1) · Last reviewed commit: "chore(docker): build the image on the to..."

The shared abnegate crates now require Rust 1.98.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant