Repository navigation
feat(route53): adopt an existing hosted zone by name (Zone.spec.adoption.byName) - #14
Merged
Merged
Conversation
…ion.byName)
Route 53 Zone adoption becomes a oneOf: {hostedZoneId: Z...} (unchanged) or
{byName: true}. By-name resolution lists same-name hosted zones, keeps those
whose private/public type matches the ZoneClass zoneType, requires exactly
one match, and records its ID in status through the existing adoption
patch; later reconciles and deletion use the recorded ID and never re-list.
Zero matches -> Programmed=False ExternalResourceNotFound; several ->
ExternalResourceMismatch with the count; both fields set -> Accepted=False
InvalidAdoption. No implicit adoption without spec.adoption; record-set
adoption, Cloudflare and VPC-association behaviour unchanged.
Motivation: appthrust/platform hosting-substrate-design.md S2 — the hosting
bundle renders Zone hcp for hcp.<installation>.internal under a Private
class; the hosted zone ID lives only in Terraform state and the installation
spec is immutable, so adoption by name removes the need to thread the ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route 53 Zone adoption becomes a oneOf: {hostedZoneId: Z...} (unchanged) or
{byName: true}. By-name resolution lists same-name hosted zones, keeps those
whose private/public type matches the ZoneClass zoneType, requires exactly
one match, and records its ID in status through the existing adoption
patch; later reconciles and deletion use the recorded ID and never re-list.
Zero matches -> Programmed=False ExternalResourceNotFound; several ->
ExternalResourceMismatch with the count; both fields set -> Accepted=False
InvalidAdoption. No implicit adoption without spec.adoption; record-set
adoption, Cloudflare and VPC-association behaviour unchanged.
Motivation: appthrust/platform hosting-substrate-design.md S2 — the hosting
bundle renders Zone hcp for hcp..internal under a Private
class; the hosted zone ID lives only in Terraform state and the installation
spec is immutable, so adoption by name removes the need to thread the ID.