Repository navigation
fix(endpoint): apex hostnames generate RFC1123-safe RecordSet names - #12
Merged
Merged
Conversation
…invalid names isolate per hostname The zone apex has relative name '@', which was embedded verbatim in the generated RecordSet metadata.name and rejected by the apiserver; the whole EndpointRecordSet reconcile then errored and no other hostname got RecordSets (observed on the AppThrust Cloud installation after the Platform Gateway started serving the apex). '@' now maps to 'apex' in metadata.name only (spec.name and hash inputs unchanged, existing names stable); an invalid generated name yields a per-hostname Resolved=False/InvalidRecordSetName condition instead of aborting the reconcile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed on the AppThrust Cloud installation: the apex relative name
@was embedded in the generated RecordSetmetadata.name, the apiserver rejected it, and the EndpointRecordSet reconcile aborted for every hostname.@→apexin the object name only (spec.name/hash unchanged, existing names stable, fixtures added); invalid names now isolate per hostname.go test ./internal/go/apps/endpoint/...green.