containertool: Read defaults from containertool.json - #179
Open
amarkdotdev wants to merge 1 commit into
Open
Conversation
Allow project-local configuration file defaults for containertool options, overridden by environment variables and CLI flags. Fixes apple#87 Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
containertool.jsonsupport socontainertoolcan load defaults for repository, registry, base image, tag, architecture, OS, and credentials.containertool.json> built-in defaults.Fixes #87
Test plan
swift build --product containertoolsucceedsswift test --filter ConfigurationFileTestscontainertool.jsonwith"repository"and confirmcontainertooluses it without--repositoryCONTAINERTOOL_REPOSITORYand confirm it overrides the config file--repositoryand confirm it overrides both env and config