[Merge] Add isolated next for AsyncMerge2Sequence#441
Open
julianiaccopucci wants to merge 1 commit into
Open
Conversation
Avoid the Swift 6 default next(isolation:) bridge so mixed throwing and non-throwing merge inputs propagate upstream failures instead of trapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next(isolation:)implementation toAsyncMerge2Sequence.Iterator.Motivation
Swift 6 async iteration can call
next(isolation:). Without an explicit implementation,AsyncMerge2Sequence.Iteratorcan fall back to the standard-library compatibility bridge through legacynext(). For mixed throwing and non-throwing inputs, that bridge can force-cast an upstream error toNeverand trap.This is related to #391.
Test plan
swift test --filter TestMerge2Isolationnext(isolation:)reproduces theFailuretoNevercast crash inTestMerge2Isolation.swift test