[AsyncStreaming] Exclude the proposal file from the target#434
Merged
Conversation
FranzBusch
requested changes
Jun 22, 2026
FranzBusch
left a comment
Member
There was a problem hiding this comment.
This was intentionally not placed in that directory. Instead we can exclude this proposal file in our Package.swift.
- NNNN-async-streaming.md is intentionally kept alongside the AsyncStreaming implementation - Exclude it from the target in Package.swift so SwiftPM no longer reports it as an unhandled file (apple#433)
294c858 to
7005e5e
Compare
Contributor
Author
Thank you Franz, makes sense. I have updated the PR to keep the proposal in place and exclude it via Package.swift instead. |
FranzBusch
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The generalized async streaming proposal,
NNNN-async-streaming.md, lives inSources/AsyncStreaming/alongside the implementation. Because it is a Markdown document rather than a build input, SwiftPM reports it as an unhandled file on every build (#433):Modifications
The proposal is intentionally kept next to the implementation, so it is excluded from the
AsyncStreamingtarget inPackage.swiftrather than being moved:Result
swift buildno longer emits the unhandled-file warning, and the proposal stays alongside the implementation.Resolves #433.