Skip to content

[AsyncStreaming] Exclude the proposal file from the target#434

Merged
FranzBusch merged 1 commit into
apple:mainfrom
kSibalic:ksibalic/move-streaming-proposal
Jun 23, 2026
Merged

[AsyncStreaming] Exclude the proposal file from the target#434
FranzBusch merged 1 commit into
apple:mainfrom
kSibalic:ksibalic/move-streaming-proposal

Conversation

@kSibalic

@kSibalic kSibalic commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Motivation

The generalized async streaming proposal, NNNN-async-streaming.md, lives in Sources/AsyncStreaming/ alongside the implementation. Because it is a Markdown document rather than a build input, SwiftPM reports it as an unhandled file on every build (#433):

warning: 'swift-async-algorithms': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
    Sources/AsyncStreaming/NNNN-async-streaming.md

Modifications

The proposal is intentionally kept next to the implementation, so it is excluded from the AsyncStreaming target in Package.swift rather than being moved:

exclude: ["NNNN-async-streaming.md"]

Result

swift build no longer emits the unhandled-file warning, and the proposal stays alongside the implementation.

Resolves #433.

@FranzBusch FranzBusch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentionally not placed in that directory. Instead we can exclude this proposal file in our Package.swift.

- NNNN-async-streaming.md is intentionally kept alongside the AsyncStreaming
implementation
- Exclude it from the target in Package.swift so SwiftPM no
longer reports it as an unhandled file (apple#433)
@kSibalic kSibalic force-pushed the ksibalic/move-streaming-proposal branch from 294c858 to 7005e5e Compare June 22, 2026 16:43
@kSibalic kSibalic changed the title [AsyncStreaming] Move evolution proposal to correct directory [AsyncStreaming] Exclude the proposal file from the target Jun 22, 2026
@kSibalic

Copy link
Copy Markdown
Contributor Author

This was intentionally not placed in that directory. Instead we can exclude this proposal file in our Package.swift.

Thank you Franz, makes sense. I have updated the PR to keep the proposal in place and exclude it via Package.swift instead.

@kSibalic kSibalic requested a review from FranzBusch June 22, 2026 16:52
@FranzBusch FranzBusch merged commit c8a9349 into apple:main Jun 23, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning: 'swift-async-algorithms': found 1 file(s) which are unhandled Sources/AsyncStreaming/NNNN-async-streaming.md

2 participants