Make squeeze and slice_by_size const folding agree with their type inference - #2803
Open
LeSingh1 wants to merge 1 commit into
Open
Make squeeze and slice_by_size const folding agree with their type inference#2803LeSingh1 wants to merge 1 commit into
LeSingh1 wants to merge 1 commit into
Conversation
…ference squeeze documents, and type_inference implements, PyTorch's rule that an axis whose size is not 1 is ignored instead of raising. value_inference handed the axes straight to np.squeeze, which raises. So squeezing a const along a non-single dimension aborted the conversion, even though the same program converts and runs when the input is not const. squeeze's zero rank result was returned as self.x.val[0], which is only a scalar when x is rank 1. For an all-ones shape of rank 2 or more this returned an array, and building the op failed with "Types should have zero rank ndarray input". Index the squeezed value instead. slice_by_size's value_inference treated any size <= 0 as "the rest of the dimension", while its type_inference (and the docstring) give that meaning to -1 only. A size of 0 therefore produced a const whose value disagreed with its own declared shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three cases where an op's
value_inferencedisagrees with its owntype_inference, so const folding changes the shape the graph was built for.squeezefolds without applying the axis rulestype_inferenceuses, andslice_by_sizefolds a negativesizedifferently from how it types it.Both now fold to match their declared output type.
Each new test fails on
mainand passes here; existing tests in the file unchanged.