[ZEPPELIN-6632] Pass the ipynb extension without a leading dot when exporting a note - #5515
Merged
Merged
Conversation
tbonelee
approved these changes
Oct 2, 2026
Contributor
|
Merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Exporting a note to ipynb from the classic UI downloads a file with two dots before the extension, e.g.
test sh..ipynb.saveAsService.saveAs()joins the file name and the extension with a dot itself, and every other call site passes the extension without one ('zpln','csv','tsv'), as does the New UI'sSaveAsService. The ipynb call site passes'.ipynb'.ZEPPELIN-4823 meant to produce
{note_name}.ipynband replaced'zepl.ipynb'with'.ipynb', butsaveAs()already added the dot at that time, so the result became{note_name}..ipynb.This passes
'ipynb', so the call site follows the same convention as the others.What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
websocket-event.factory.test.jsnow replacessaveAsServicewith a spy and checks that aCONVERTED_NOTE_NBFORMATmessage saves with'ipynb'. The test fails with the previous'.ipynb'argument.I also checked the resulting download name with the real
saveAsServiceby capturing the anchor'sdownloadattribute:test sh..ipynbbefore the change,test sh.ipynbafter.