[ZEPPELIN-6722] Record the pinned Angular notebook route baseline - #5512
Merged
Merged
Conversation
Record 10 cold and 10 warm samples of the notebook route benchmark from ZEPPELIN-6668 at 7f7b995, before the React route host (ZEPPELIN-6675) lands. Raw samples, the summary and the environment record are committed under e2e/performance/baselines/. The README now points to the recorded baseline and notes that note import needs at least one interpreter (the fixture uses %sh).
voidmatcha
approved these changes
Sep 29, 2026
voidmatcha
left a comment
Member
There was a problem hiding this comment.
Verified the recorded samples and summary, and confirmed that the benchmark contract completes successfully in dry-run mode. LGTM 👍
Member
|
Merged into master (28894a1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Record the pinned Angular notebook route baseline with the benchmark contract from ZEPPELIN-6668, before the React route host (ZEPPELIN-6675) lands and the current Angular path can no longer be measured under the same conditions.
7f7b995c3(the ZEPPELIN-6668 merge, currentmaster), with a clean working tree (workingTreeDirty: false).notebookReadyMsfcpMsRaw samples: cold 1092.4–1181.9 ms, warm 768.9–871.6 ms. The JSON files are authoritative; the table rounds to 0.1 ms.
Entry bundles (raw / gzip bytes):
main6,691,449 / 1,786,481,scripts825,757 / 238,428,styles136,950 / 23,253,polyfills56,102 / 20,644; ReactremoteEntry.js4,109 / 1,785.Environment: macOS (Darwin 23.6.0), Apple M3 Pro, 36 GiB, Playwright Chromium 140.0.7339.186, Node v22.21.1 (the
.nvmrcversion), AC power. Zeppelin was built from the same commit (zeppelin-serverwith its dependencies, andshell), with anonymous access and an empty isolated notebook directory. Measurement started after the post-build Spotlight indexing settled (1-minute load average 3.8).Files:
e2e/performance/baselines/70eef3f8-….raw.json/.summary.json: added withgit add -f, as the README describes, because generated outputs stay git-ignored.e2e/performance/README.md: the sentence saying there is no pinned baseline now points to the recorded one, and aRecorded Angular baselinesection lists the commit, environment and summary. It also notes that note import needs at least one interpreter. With none installed, import fails with HTTP 500 (InterpreterSettingManager.getDefaultInterpreterSettingthrowsIndexOutOfBoundsException). The fixture's paragraphs use%sh, so buildingshellis enough. No existing sentence was removed; the two changed lines keep their original content.What type of PR is it?
Improvement
Todos
mastercommitWhat is the Jira issue?
ZEPPELIN-6722
How should this be tested?
What I ran locally:
zlibgzip bytes match the builtdistfiles.Benchmark fixture SHA-256 mismatch. The fixture was restored before committing.Numbers from a different machine are not expected to match. Compare a later run with this baseline only when it was recorded in the same environment.
Screenshots (if appropriate)
N/A.
Questions:
**/*.jsonexclusion.🤖 Generated with Claude Code