[ZEPPELIN-6584] Fix reversed line diff direction in New UI revision comparator - #5507
Merged
Merged
Conversation
jongyoul
approved these changes
Sep 29, 2026
jongyoul
left a comment
Member
There was a problem hiding this comment.
Reviewed fa674b0. The first/from -> second/to direction now matches the selectors and insert/delete rendering, while whole-paragraph classification is preserved. The five focused comparator tests passed in both exact-head CI jobs; an isolated exact-source probe also distinguished the fix from the reversed-direction baseline. No actionable issue found in this bounded change.
CI is not fully green: the auth keyboard E2E failed while waiting on PENDING, the anonymous classic phase was cancelled, and Selenium setup hit a Maven Central download timeout. This is a code-review approval, not confirmation that all merge checks have passed.
voidmatcha
approved these changes
Sep 30, 2026
Member
|
Merged into master (45f305a). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The New UI revision comparator labels a comparison as
first --> second(e.g.older --> newer), butcompareRevisions()built the line-level diff from the second revision back to the first. As a result, added lines were rendered as red deletions and removed lines as green insertions for paragraphs present in both revisions.This PR computes the line diff in the same
first --> seconddirection shown in the UI, matching the legacy AngularJS comparator (diffLines(firstText, secondText)). The whole-paragraphadded/deletedclassification, which was already correct, is unchanged.What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
ZEPPELIN-6584
How should this be tested?
Screenshots (if appropriate)
Questions: