[ZEPPELIN-6719] Improve argument validation and error handling in bin/zeppelin.sh - #5495
Open
ParkGyeongTae wants to merge 1 commit into
Open
ParkGyeongTae wants to merge 1 commit into
ParkGyeongTae wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR improves the robustness of
bin/zeppelin.shby adding argumentvalidation and consistent error handling during Zeppelin startup.
The changes include safer handling of anonymous container UIDs, validation of
the
--configand--runoptions, improved Hadoop classpath error handling,and failure checks when creating log and PID directories.
The
--versionoption can now return the Zeppelin version without performingthe Java version check.
What type of PR is it?
Bug Fix
Todos
--configand--runWhat is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6719
How should this be tested?
Run the following commands and verify the expected behavior:
./bin/zeppelin.sh --version./bin/zeppelin.sh --config./bin/zeppelin.sh --runThe script was also verified with: