Skip to content

[ZEPPELIN-6719] Improve argument validation and error handling in bin/zeppelin.sh - #5495

Open
ParkGyeongTae wants to merge 1 commit into
apache:masterfrom
ParkGyeongTae:ZEPPELIN-6719
Open

ParkGyeongTae wants to merge 1 commit into
apache:masterfrom
ParkGyeongTae:ZEPPELIN-6719

Conversation

@ParkGyeongTae

Copy link
Copy Markdown
Member

What is this PR for?

This PR improves the robustness of bin/zeppelin.sh by adding argument
validation and consistent error handling during Zeppelin startup.

The changes include safer handling of anonymous container UIDs, validation of
the --config and --run options, improved Hadoop classpath error handling,
and failure checks when creating log and PID directories.

The --version option can now return the Zeppelin version without performing
the Java version check.

What type of PR is it?

Bug Fix

Todos

  • - Add argument validation for --config and --run
  • - Improve Hadoop command and classpath error handling
  • - Handle log and PID directory creation failures
  • - Improve anonymous container UID handling

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6719

How should this be tested?

Run the following commands and verify the expected behavior:

  • ./bin/zeppelin.sh --version
  • ./bin/zeppelin.sh --config
  • ./bin/zeppelin.sh --run
  • Test with an invalid Hadoop configuration.
  • Test Hadoop classpath command failure.
  • Test failure to create the log or PID directory.
  • Test Zeppelin startup with an anonymous container UID.

The script was also verified with:

git diff --check

### Screenshots (if appropriate)

Not applicable.

### Questions:

- Does the license files need to update?
  No.

- Is there breaking changes for older versions?
  No.

- Does this need documentation?
  No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant