[ZEPPELIN-6716] Update links in NOTICE - #5491
Merged
Merged
Conversation
voidmatcha
reviewed
Sep 20, 2026
|
|
||
| * Pseudo terminal(PTY) implementation in Java | ||
| * (Eclipse Public License) pty4j - http://www.eclipse.org/legal/epl-v10.html | ||
| * (Eclipse Public License) pty4j - https://www.eclipse.org/legal/epl-v10.html |
Member
There was a problem hiding this comment.
The new https URL still redirects once, to the path below.
Suggested change
| * (Eclipse Public License) pty4j - https://www.eclipse.org/legal/epl-v10.html | |
| * (Eclipse Public License) pty4j - https://www.eclipse.org/legal/epl/epl-v10.html |
Member
Author
There was a problem hiding this comment.
Thanks for catching this. Updated the pty4j license URL in NOTICE to the final HTTPS URL to avoid the redirect.
Member
Author
|
Merged into master (9b271d5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR updates the root NOTICE file.
It removes the unavailable NFLabs website URL while preserving the
attribution to NFLabs, Inc., and changes the pty4j Eclipse Public
License URL from HTTP to HTTPS.
What type of PR is it?
Documentation
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6716
How should this be tested?
No automated tests are required because this is a documentation-only change.
The final diff should be reviewed to confirm that only NOTICE was modified.
Screenshots (if appropriate)
Not applicable.
Questions:
Does the license files need to update?
No additional license files need to be updated. This PR only updates NOTICE.
Is there breaking changes for older versions?
No.
Does this needs documentation?
No additional documentation is needed.