Skip to content

[ZEPPELIN-6465] Extract magic numbers in EmbeddingSearch.saveIndex() into named constants #5489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voidmatcha merged 1 commit into from
Sep 20, 2026
+13 −4
Merged

[ZEPPELIN-6465] Extract magic numbers in EmbeddingSearch.saveIndex() into named constants #5489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions zeppelin-server/src/main/java/org/apache/zeppelin/search/EmbeddingSearch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,15 @@ public class EmbeddingSearch extends SearchService {
*/
private static final float MIN_SIMILARITY = 0.25f;
private static final int MAX_TEXT_LENGTH = 1500;
/**
* Truncation limit applied to the text field when an entry is written to the index file.
* Distinct from {@link #MAX_TEXT_LENGTH}, which bounds in-memory processing before embedding.
*/
private static final int MAX_PERSISTED_TEXT_LENGTH = 2000;
/**
* Truncation limit applied to the output field when an entry is written to the index file.
*/
private static final int MAX_PERSISTED_OUTPUT_LENGTH = 1000;

static final String ID_FIELD = "id";
private static final String PARAGRAPH = "paragraph";
Expand Down Expand Up @@ -868,15 +877,15 @@ private void saveIndex() throws IOException {
out.writeUTF(e.getKey());
out.writeUTF(e.getValue().noteName != null ? e.getValue().noteName : "");
String text = e.getValue().text != null ? e.getValue().text : "";
if (text.length() > 2000) {
text = text.substring(0, 2000);
if (text.length() > MAX_PERSISTED_TEXT_LENGTH) {
text = text.substring(0, MAX_PERSISTED_TEXT_LENGTH);
}
out.writeUTF(text);
out.writeUTF(e.getValue().title != null ? e.getValue().title : "");
out.writeUTF(e.getValue().tables != null ? e.getValue().tables : "");
String output = e.getValue().output != null ? e.getValue().output : "";
if (output.length() > 1000) {
output = output.substring(0, 1000);
if (output.length() > MAX_PERSISTED_OUTPUT_LENGTH) {
output = output.substring(0, MAX_PERSISTED_OUTPUT_LENGTH);
}
out.writeUTF(output);
for (float v : e.getValue().embedding) {
Expand Down
Loading