[ZEPPELIN-6661] Cover notebook editor save timing - #5483
Open
voidmatcha wants to merge 2 commits into
Open
voidmatcha wants to merge 2 commits into
voidmatcha wants to merge 2 commits into
Conversation
voidmatcha
force-pushed
the
ZEPPELIN-6661-editor-save-timing
branch
4 times, most recently
from
September 15, 2026 16:36
532b535 to
68184b0
Compare
voidmatcha
marked this pull request as ready for review
September 16, 2026 13:17
voidmatcha
force-pushed
the
ZEPPELIN-6661-editor-save-timing
branch
7 times, most recently
from
September 17, 2026 18:17
ee99efb to
6d323f2
Compare
Member
Author
|
This is why the PR changes Angular code. On master, an edit typed while a save is in flight is overwritten when the delayed save response arrives. This branch puts only this PR's E2E files on master, without the fix: https://github.com/voidmatcha/zeppelin/tree/ZEPPELIN-6661-repro-on-master CI results (Playwright, anonymous mode):
Angular changes:
|
voidmatcha
force-pushed
the
ZEPPELIN-6661-editor-save-timing
branch
from
September 20, 2026 02:12
5697900 to
f350173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When a paragraph save response arrives late,
ParagraphBasetreats it as a remote update and replaces the editor text, losing edits typed in the meantime.This PR tracks pending saves by
msgId. A response to one of the user's own saves no longer replaces the editor text when a newer edit or save followed it; otherwise the response is the server copy and is applied as before. Other paragraph fields in that response always apply.Related behavior changes in
ParagraphBase:This PR adds the E2E scenarios for ZEPPELIN-6661 (idle autosave, edit during an in-flight save). The in-flight scenario fails without this fix, so the fix is included here.
What type of PR is it?
Bug Fix
Todos
msgIdWhat is the Jira issue?
ZEPPELIN-6661
How should this be tested?
cd zeppelin-web-angular npx vitest run --config vitest.shell.config.mts src/app/core/paragraph-base/paragraph-base.spec.ts npm run check:notebook-parity-scenarios CI=true PLAYWRIGHT_HTML_OPEN=never npm run e2e -- --reporter=list tests/notebook/persistence/notebook-save-timing.spec.tsScreenshots (if appropriate)
N/A
Questions: